On 2014-11-16 18:13:35 +0200, Martin Storsjö wrote: > This reverts commit c00365b46d464ce47716315c1801818d811bdb9a > in addition to using a different section.
the revert is ok > --- > Not sure if the ifdef __linux__ is necessary, we don't support > aarch64 on any other OSes than linux and iOS yet. I'm not actually sure how linux specific .data.rel.ro is. It seems to have leaked into other unices using ELF. Not that any of them support aarch64 yet. > diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S > index b766e67..0bd2966 100644 > --- a/libavutil/aarch64/asm.S > +++ b/libavutil/aarch64/asm.S > @@ -66,6 +66,22 @@ ELF .size \name, . - \name > \name: > .endm > > +.macro constrel name, align=2 unrelated, why didn't I change the default align value to 3? I'll send a patch > + .macro endconstrel > +ELF .size \name, . - \name > + .purgem endconstrel > + .endm > +#ifdef __linux__ > + .section .data.rel.ro > +#elif defined(__MACH__) > + .const_data > +#else > + .section .rodata > +#endif > + .align \align > +\name: > +.endm I would prefer an option for the const macro to use a special relocateble section like for arm although it would look less clean since we need to support llvm directly. Janne _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
