On Sun, 16 Nov 2014, Martin Storsjö wrote:
On Sun, 16 Nov 2014, Martin Storsjö wrote:
---
Using ifdef __linux__ for .data.rel.ro, since we support some
other (ancient) setups which don't support such a section
(in particular, symbian, which still uses elf object files in the
build, but where the toolchain can't handle such a section).
---
libavcodec/arm/fft_fixed_neon.S | 4 ++--
libavcodec/arm/fft_neon.S | 4 ++--
libavcodec/arm/fft_vfp.S | 4 ++--
libavutil/arm/asm.S | 14 ++++++++++++++
4 files changed, 20 insertions(+), 6 deletions(-)
Since all of these only are used on entry (just like fft/opus on aarch64), we
could also use the same trick as currently there, to make the tables
completely relocation-free - that'd use fewer fancy features about section
types etc.
Actually, no, that doesn't work too well. Note to self, with armasm it
fails due to "error A2009: '-' can not be applied; different sections or
different base registers", and iirc even if it'd be in the same section,
armasm still has got a bug in calculating label differences. This same
issue was discussed when the fft_vfp stuff was added a few months ago.
Back then, I also saw an issue with the apple tools, but when looking at
it now, it seems that particular issue only appeared as long as it used
.short entries - apple tools don't seem to have any issues when it's using
.word for label differences.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
