When all the codepaths using manually set .arch/.fpu code is
behind runtime detection, the elf attributes should be suppressed.

This allows tools to know that the final built binary doesn't
strictly require these extensions.
---
Ideally, these should only be added on platforms where we have
runtime detection (i.e. linux). So on non-linux, ELF platforms,
they should in theory be omitted. Adding #ifdef __linux__ around
them do feel like overkill though.
---
 libavutil/arm/asm.S |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavutil/arm/asm.S b/libavutil/arm/asm.S
index 8479304..63e292d 100644
--- a/libavutil/arm/asm.S
+++ b/libavutil/arm/asm.S
@@ -49,9 +49,12 @@
 #elif HAVE_ARMV5TE
         .arch           armv5te
 #endif
+ELF     .object_arch    armv4
 
 #if   HAVE_NEON
         .fpu            neon
+ELF     .eabi_attribute 10, 0           @ suppress Tag_FP_arch
+ELF     .eabi_attribute 12, 0           @ suppress Tag_Advanced_SIMD_arch
 #elif HAVE_VFP
         .fpu            vfp
 #endif
-- 
1.7.10.4

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to