On Sun, 1 Mar 2015, Diego Biurrun wrote:
On Sun, Mar 01, 2015 at 10:46:33PM +0200, Martin Storsjö wrote:
On Sun, 1 Mar 2015, Diego Biurrun wrote:
On Fri, Feb 27, 2015 at 01:00:57PM +0200, Martin Storsjö wrote:
Intentionally keeping some conditional statements on single lines
in rtpenc_h263.c.
---
libavformat/rtpenc.c | 3 ++-
libavformat/rtpenc_xiph.c | 6 ++++--
2 files changed, 6 insertions(+), 3 deletions(-)
How about K&Ring the whole files instead? Yes, I'm volunteering.
I don't see a direct need. Most of these files are quite readable and mostly
very close to our common standard.
You're touching the file already in this respect.
Yes.
Better change it once and for all than going back and touching it at
another point in the future. Less noise in the history and all that ...
No.
Yes, I'm touching the file. I'm touching very small and easy to read
sections. Such a touch is less costly than touching every single line in
the file to me, and to people reviewing it, and to people reviewing the
history of the file, and to people cherrypicking fixes back and forth.
The file is mostly fine and does not warrant a huge monster patch.
Yes, there might actually be a few "if(" or "switch(" there. But don't you
dare send a patch that does any insignificant vertical alignment or other
completely irrelevant shuffling.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
