On Sun, Mar 01, 2015 at 11:24:18PM +0200, Martin Storsjö wrote: > On Sun, 1 Mar 2015, Diego Biurrun wrote: > >On Sun, Mar 01, 2015 at 10:15:14PM +0100, Anton Khirnov wrote: > >>Quoting Diego Biurrun (2015-03-01 21:27:30) > >>>On Fri, Feb 27, 2015 at 01:00:57PM +0200, Martin Storsjö wrote: > >>>>Intentionally keeping some conditional statements on single lines > >>>>in rtpenc_h263.c. > >>>>--- > >>>> libavformat/rtpenc.c | 3 ++- > >>>> libavformat/rtpenc_xiph.c | 6 ++++-- > >>>> 2 files changed, 6 insertions(+), 3 deletions(-) > >>> > >>>How about K&Ring the whole files instead? Yes, I'm volunteering. > >> > >>Stab. > >> > >>As I've said many times before -- complete whole-file reformatting > >>should be a last-resort measure applied to terrible unreadable files > >>(like ye olde days mpegvideo). We used to have many such files, so it > >>seems some of use have gotten used to doing it all the time, but > >>it's a very bad idea to keep doing this on files that are mostly fine. > >>It creates unnecessary noise in the history, is hard and annoying to > >>review properly and breaks outstanding work. > > > >And that's precisely why I'm proposing to do it once (and for all) instead > >of changing little bits here and there, thus littering the history with > >cleanup commits... > > "Once and for all", until 6 months later when somebody else comes along and > redoes with slightly different uncrustify/whatever tool config, and then > someone else comes along again? You really don't see that this is an issue, > do you?
I very much agree that this would be an issue, but I have never seen it happen, nor do I expect it to ever happen. K&R style is fixed and our uncrustify config is pretty stable. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
