On Sat, 2 May 2015, Diego Biurrun wrote:

On Sat, May 02, 2015 at 11:34:04AM +0300, Martin Storsjö wrote:
From: Matt Oliver <[email protected]>

Only MSVC 2010 in x64 mode, in the static msvcrt, had a
stray log2 function (which wasn't available in the headers).

MSVC 2013 has got a proper log2 function though.
---
 configure | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 0620615..d24b87e 100755
--- a/configure
+++ b/configure
@@ -1744,7 +1744,6 @@ fast_unaligned_if_any="aarch64 ppc x86"

 # system capabilities
-log2_deps="!libc_msvcrt"

 symver_if_any="symver_asm_label symver_gnu_asm"
 valgrind_backtrace_deps="!optimizations valgrind_valgrind_h"

You should also drop the variable from HAVE_LIST.

Do you mean "the variable" as in libc_msvcrt? We still need it for other things, grep for HAVE_LIBC_MSVCRT.

Also, please drop the empty line between declaration blocks and
change the comment to "toolchain capabilities", which is more
fitting.

Ok, will do.

IIUC symbol versioning is more a toolchain than a system capability.

It's both - the two details listed here are toolchain capabilities, but it also requires support from the runtime linker (which the android/bionic linker lacks, which is why it is explicitly disabled in the --target-os=android case, even if the toolchain supports it just fine).

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to