On Sat, May 02, 2015 at 08:21:33PM +0300, Martin Storsjö wrote: > On Sat, 2 May 2015, Martin Storsjö wrote: > >On Sat, 2 May 2015, Diego Biurrun wrote: > >>On Sat, May 02, 2015 at 11:34:04AM +0300, Martin Storsjö wrote: > >>>From: Matt Oliver <[email protected]> > >>>--- a/configure > >>>+++ b/configure > >>>@@ -1744,7 +1744,6 @@ fast_unaligned_if_any="aarch64 ppc x86" > >>> > >>> # system capabilities > >>>-log2_deps="!libc_msvcrt" > >>> > >>> symver_if_any="symver_asm_label symver_gnu_asm" > >>> valgrind_backtrace_deps="!optimizations valgrind_valgrind_h" > >> > >>You should also drop the variable from HAVE_LIST. > > > >Do you mean "the variable" as in libc_msvcrt? We still need it for other > >things, grep for HAVE_LIBC_MSVCRT.
You are right. > >>Also, please drop the empty line between declaration blocks and > >>change the comment to "toolchain capabilities", which is more > >>fitting. > > > >Ok, will do. > > Actually, I still think "system capabilities" is more appropriate for symver > and valgrind_backtrace than toolchain. OK, keep that comment if you prefer but please drop the empty line. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
