On 05/05/15 15:17, Vittorio Giovara wrote: > On Sat, May 2, 2015 at 5:39 AM, Anton Khirnov <[email protected]> wrote: >> Quoting Vittorio Giovara (2015-05-02 01:17:09) >>> This field is used only to report compression statistics, setting any >>> other field is unsupported. >>> >>> Rather than setting random properties in this field, use or add >>> alternative values from either context or input frame. >>> >>> Do not overwrite its pointer, and do not fill it twice. >>> >>> Signed-off-by: Vittorio Giovara <[email protected]> >>> --- >> >> I'm ambiguous about this patch, it seems to me it does too many things >> at once and the justification in the commit message is very >> vague/handwavy. >> >> You cannot just drop things that might still be used by people without a >> good reason, a proper replacement and a deprecation period, even if the >> API is insane. > > The problem is that there was no definite way of handling this, eg > some encoders would set completely random fields. It's not a matter of > insanity, but rather being unpredictable and thus unusable from the > api user. > I am referring in particular to setting interlaced and pts which are > information already available to the caller. > Also this was never properly documented, so removing them is as bad as > keeping them imho. >
I'd just use your patch, not that the caller would really notice, some codecs even did not set it to begin with. The patch is Ok as is for me if you add more context in the patch comment and write down in the wiki some notes about it. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
