Quoting Vittorio Giovara (2015-05-05 15:20:23)
> On Tue, May 5, 2015 at 2:17 PM, Vittorio Giovara
> <[email protected]> wrote:
> > On Sat, May 2, 2015 at 5:39 AM, Anton Khirnov <[email protected]> wrote:
> >> Quoting Vittorio Giovara (2015-05-02 01:17:09)
> >>> This field is used only to report compression statistics, setting any
> >>> other field is unsupported.
> >>>
> >>> Rather than setting random properties in this field, use or add
> >>> alternative values from either context or input frame.
> >>>
> >>> Do not overwrite its pointer, and do not fill it twice.
> >>>
> >>> Signed-off-by: Vittorio Giovara <[email protected]>
> >>> ---
> >>
> >> I'm ambiguous about this patch, it seems to me it does too many things
> >> at once and the justification in the commit message is very
> >> vague/handwavy.
> 
> Would it be better if I split it into different parts?

Yes.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to