On Sun, May 10, 2015 at 9:58 PM, Stefano Pigozzi <[email protected]> wrote: > On Sun, May 10, 2015 at 11:05 AM, Hendrik Leppkes <[email protected]> wrote: > >> To be slightly constructive about this: >> Skip the avclass, i'm not sure why there is an avoption for this one >> thing anyway? > > This is needed for client programs to ask the decoder for NV12 > surfaces (which introduce less overhead). I fixed the commit message > and added a sentence explaining why the change is useful.
I'm not questioning why the option itself exists, but why it got an AVOption (and thus an AVClass). =) > >> Instead add the new member to the end of the struct, and init it to >> its default value in the allocation function (av_vda_alloc_context) >> That way the ABI remains stable, and you get the same end-result. > > Thanks for the feedback. Please see the attached patch. I also updated > my test code for this https://github.com/mpv-player/mpv/tree/vda_nv12 > > _______________________________________________ > libav-devel mailing list > [email protected] > https://lists.libav.org/mailman/listinfo/libav-devel _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
