On Mon, May 11, 2015 at 12:08 PM, Luca Barbato <[email protected]> wrote:
> On 10/05/15 21:58, Stefano Pigozzi wrote:
>> On Sun, May 10, 2015 at 11:05 AM, Hendrik Leppkes <[email protected]> 
>> wrote:
>>
>>> To be slightly constructive about this:
>>> Skip the avclass, i'm not sure why there is an avoption for this one
>>> thing anyway?
>>
>> This is needed for client programs to ask the decoder for NV12
>> surfaces (which introduce less overhead). I fixed the commit message
>> and added a sentence explaining why the change is useful.
>>
>>> Instead add the new member to the end of the struct, and init it to
>>> its default value in the allocation function (av_vda_alloc_context)
>>> That way the ABI remains stable, and you get the same end-result.
>>
>> Thanks for the feedback. Please see the attached patch. I also updated
>> my test code for this https://github.com/mpv-player/mpv/tree/vda_nv12
>>
>
> Everybody is fine with it?


No further comments on the patch if its tested to work.

- Hendrik
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to