On Thu, May 28, 2015 at 5:09 PM, James Almer <[email protected]> wrote:
> On 28/05/15 9:11 AM, Vittorio Giovara wrote:
>> On Wed, May 27, 2015 at 7:24 PM, James Almer <[email protected]> wrote:
>>> As Luca said, require_pkg_config. If you use require, "vpx >= 1.4.0" is
>>> just used as a name
>>> to report a failure. It does not check for that version.
>>
>> I swear I couldn't get it working with just require_pkg_config, thanks
>> for showing how to do that in the next email.
>
> For the record, the example i gave in the other email is only valid if the
> libvpx
> requirement is bumped to 1.3.0 or newer. Otherwise, individual tests for each
> component
> (like it's done right now) will still be needed.
Ok I'll let the discussion settle on which version to support and then amend.
>>>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>>>> index 3440126..16af20c 100644
>>>> --- a/libavcodec/avcodec.h
>>>> +++ b/libavcodec/avcodec.h
>>>> @@ -2702,6 +2702,10 @@ typedef struct AVCodecContext {
>>>> #define FF_PROFILE_JPEG2000_DCINEMA_2K 3
>>>> #define FF_PROFILE_JPEG2000_DCINEMA_4K 4
>>>>
>>>> +#define FF_PROFILE_VP9_0 0
>>>> +#define FF_PROFILE_VP9_1 1
>>>> +#define FF_PROFILE_VP9_2 2
>>>> +#define FF_PROFILE_VP9_3 3
>>>
>>> Even if it's a simple change, credit where credit is due would be nice.
>>
>> credit to whom and for what?
>
> https://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=079b7f6eacc09bc2813fc1ddc230ab05022b69c2
> https://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=01e59d48ed1a41b88107ed1d4d56ae0cbcd1a60e
Interesting, as you know, I have no problem in giving credit where
credit is due (done so several times); however I did not copy that
code, and written it from scratch, so I think I'll keep it like this.
Cheers.
--
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
