On 28/10/15 15:54, Vittorio Giovara wrote:
> This function returns the encoded data of a frame, one slice at a time
> directly when that slice is encoded, instead of waiting for the full
> frame to be done.

The name is misleading, but it isn't rtp-specific in any way.

> The usefulness of this field is debatable, and it looks like it is
> mainly a convoluted way to get data at lowest possible latency, and
> only when transmitting over RTP (despite not being enforced by any means).


Fix the typos below

> Moreover when mulithreading is enabled (which is by defaul) the order
> of returned slices is not deterministic at all, making the use of this
> function not reliable at all (or at the very least, more complicated
> than it should be).
> 

Drop the part below, it isn't true.

> So, for the reasons stated above, and being used by only a single encoder
> (mpegvideo), and theoretically available only through a single muxer (rtp),
> this field is deemed unnecessary, overcomplicated, and not belonging
> to libavcodec.



> 
> Signed-off-by: Vittorio Giovara <[email protected]>
> ---
>  libavcodec/avcodec.h       | 6 ++++++
>  libavcodec/mpegvideo_enc.c | 8 ++++++++
>  libavcodec/version.h       | 3 +++
>  3 files changed, 17 insertions(+)


Thanks to making the patch correct

lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to