On Wed, Oct 28, 2015 at 4:05 PM, Luca Barbato <[email protected]> wrote: >> >> Signed-off-by: Vittorio Giovara <[email protected]> >> --- >> libavcodec/avcodec.h | 6 ++++++ >> libavcodec/mpegvideo_enc.c | 8 ++++++++ >> libavcodec/version.h | 3 +++ >> 3 files changed, 17 insertions(+)
amended: This function returns the encoded data of a frame, one slice at a time directly when that slice is encoded, instead of waiting for the full frame to be done. The usefulness of this field is debatable, the name is misleading, as it isn't rtp-specific in any way, and it looks like it is mainly a convoluted way to get data at lowest possible latency, and only when transmitting over RTP (despite not being enforced by any means). Moreover when multi-threading is enabled (which is by default) the order of returned slices is not deterministic at all, making the use of this function not reliable at all (or at the very least, more complicated than it should be). So, for the reasons stated above, and being used by only a single encoder (mpegvideo), in a very misleading way, this field is deemed unnecessary, overcomplicated, and not belonging to libavcodec. this is pretty much RFC, if users have legit usecases for this code please speak up -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
