On Fri, 20 Nov 2015, Luca Barbato wrote:

On 20/11/15 12:36, Vittorio Giovara wrote:

Martin, I am aware of what was explained,

Andreas seemed to have missed your previous explanation and Martin's.

If you still prefer that I completely remove any reference to
AVFormat, I'll do so.

I'd keep it so whoever has the wrong idea that for rfc-2190 the callback
is *needed* gets some directions.

Either they copy from muxer or they use libavformat.

The patch in itself is good for everybody I think.

Right - yes, for RFC 2190 this callback might be helpful, somewhat at least. Although I think it only helps with the really trivial case which you can fix yourself by just looking for simple startcodes, not for the less trivial case that the RFC 2190 code in our muxer mostly is about. (Sorry I didn't read the updated commit message, only the contents of the patch.)

Perhaps it would be less confusing to extend the APIchanges entry to something like this:

"Deprecate rtp_callback, the libavformat rtpenc muxer can be used for RFC 2190 packetization" or so.

Although I won't block this patch any further.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to