On Thu, Jan 21, 2016 at 3:05 AM, Diego Biurrun <[email protected]> wrote: > On Wed, Jan 20, 2016 at 10:53:38AM -0500, Vittorio Giovara wrote: >> On Wed, Jan 20, 2016 at 4:59 AM, Diego Biurrun <[email protected]> wrote: >> >> + src += 2 * src_wrap; >> >> + dst += dst_wrap; >> >> + } >> >> +} >> > >> > You've reformatted the code while moving. This is nice and all, but I fear >> > it might throw off the Git copy detection routines. I would suggest doing >> > a reformatting as preliminary step instead. >> >> doesn't git copy work only on full files anyway? > > I didn't speak of git-copy the command. I think Git can track pieces of > code around, too.
I fear this is too much speculation for now, and people in the past rejected style-only commits, so I'll skip this part of the review. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
