On Thu, Jan 21, 2016 at 12:19 PM, Diego Biurrun <[email protected]> wrote: > On Thu, Jan 21, 2016 at 11:59:22AM -0500, Vittorio Giovara wrote: >> On Thu, Jan 21, 2016 at 3:05 AM, Diego Biurrun <[email protected]> wrote: >> > On Wed, Jan 20, 2016 at 10:53:38AM -0500, Vittorio Giovara wrote: >> >> On Wed, Jan 20, 2016 at 4:59 AM, Diego Biurrun <[email protected]> wrote: >> >> >> + src += 2 * src_wrap; >> >> >> + dst += dst_wrap; >> >> >> + } >> >> >> +} >> >> > >> >> > You've reformatted the code while moving. This is nice and all, but I >> >> > fear >> >> > it might throw off the Git copy detection routines. I would suggest >> >> > doing >> >> > a reformatting as preliminary step instead. >> >> >> >> doesn't git copy work only on full files anyway? >> > >> > I didn't speak of git-copy the command. I think Git can track pieces of >> > code around, too. >> >> [...] people in the past rejected style-only commits, [...] > > What universe was that in? > > ~/src/libav $ git log --oneline | grep "K&R formatting" | wc -l > 170
Not worth the time to search irc or ml logs, but the fact that the last k&r was done more than a year ago should tip you off -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
