On 26/3/16 10:34, Janne Grunau wrote:
Yes, the sample previously output BGRA (32bits) only, however the sample was actually BGR (24bits). So the same file produces different hashes because the output pixel format is changed. While I was at it, I renamed the sample too, so that it would be uniform with the other samples names. Should I maybe mention this in the commit log?On 2016-03-26 09:45:59 +0100, Vittorio Giovara wrote:--- tests/fate/screen.mak | 13 +++++++++++-- tests/ref/fate/rscc | 6 ------ tests/ref/fate/rscc-16bit | 16 ++++++++++++++++ tests/ref/fate/rscc-24bit | 1 + tests/ref/fate/rscc-32bit | 9 +++++++++ 5 files changed, 37 insertions(+), 8 deletions(-) delete mode 100644 tests/ref/fate/rscc create mode 100644 tests/ref/fate/rscc-16bit create mode 100644 tests/ref/fate/rscc-24bit create mode 100644 tests/ref/fate/rscc-32bit diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak index 82d4861..502645e 100644 --- a/tests/fate/screen.mak +++ b/tests/fate/screen.mak @@ -41,8 +41,17 @@ fate-g2m4: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/g2m/g2m4.asf FATE_SAMPLES_AVCONV-$(call DEMDEC, ASF, G2M) += $(FATE_G2M) fate-g2m: $(FATE_G2M)-FATE_SAMPLES_AVCONV-$(call DEMDEC, AVI, RSCC) += fate-rscc-fate-rscc: CMD = framecrc -i $(TARGET_SAMPLES)/rscc/pip.avi -anis there a reason to replace this tests instead of renaming it simply to fate-rscc-32bit? It would help (a little) to keep the fate samples repo size down
I'll remove the old file in a couple of days to keep the fate size down.
+FATE_RSCC += fate-rscc-16bit +fate-rscc-16bit: CMD = framecrc -i $(TARGET_SAMPLES)/rscc/16bpp_555.avi -an + +FATE_RSCC += fate-rscc-24bit +fate-rscc-24bit: CMD = framecrc -i $(TARGET_SAMPLES)/rscc/24bpp.avi -an + +FATE_RSCC += fate-rscc-32bit +fate-rscc-32bit: CMD = framecrc -i $(TARGET_SAMPLES)/rscc/32bpp.avi -an + +FATE_SAMPLES_AVCONV-$(call DEMDEC, AVI, RSCC) += $(FATE_RSCC) +fate-rscc: $(FATE_RSCC)FATE_SAMPLES_AVCONV-$(call DEMDEC, AVI, SCREENPRESSO) += fate-screenpressofate-screenpresso: CMD = framecrc -i $(TARGET_SAMPLES)/spv1/bunny.avi diff --git a/tests/ref/fate/rscc b/tests/ref/fate/rscc deleted file mode 100644 index 69dbfe1..0000000 --- a/tests/ref/fate/rscc +++ /dev/null @@ -1,6 +0,0 @@ -#tb 0: 1/10 -0, 0, 0, 1, 6814720, 0x1365f8ef -0, 1, 1, 1, 6814720, 0x90838983 -0, 2, 2, 1, 6814720, 0xf0cc3131 -0, 3, 3, 1, 6814720, 0xc07e404d -0, 4, 4, 1, 6814720, 0x945962dd diff --git a/tests/ref/fate/rscc-16bit b/tests/ref/fate/rscc-16bit new file mode 100644 index 0000000..85d5494 --- /dev/null +++ b/tests/ref/fate/rscc-16bit @@ -0,0 +1,16 @@ +#tb 0: 100/2397 +0, 0, 0, 1, 153600, 0x33759daf +0, 1, 1, 1, 153600, 0x43e0c910 +0, 2, 2, 1, 153600, 0x6c75a8f0 +0, 3, 3, 1, 153600, 0xaace1255 +0, 4, 4, 1, 153600, 0x42d3f439 +0, 5, 5, 1, 153600, 0xb225b396 +0, 6, 6, 1, 153600, 0xa615221c +0, 7, 7, 1, 153600, 0x5401f5a9 +0, 8, 8, 1, 153600, 0xd274cef3 +0, 9, 9, 1, 153600, 0x7935f992 +0, 10, 10, 1, 153600, 0x7669e7c6 +0, 11, 11, 1, 153600, 0x527bd6a1 +0, 12, 12, 1, 153600, 0x0f33b2ed +0, 13, 13, 1, 153600, 0xe62ddb32 +0, 14, 14, 1, 153600, 0x81541aa2 diff --git a/tests/ref/fate/rscc-24bit b/tests/ref/fate/rscc-24bit new file mode 100644 index 0000000..f5b215d --- /dev/null +++ b/tests/ref/fate/rscc-24bit @@ -0,0 +1 @@ +#tb 0: 1/10the fate-rscc-24bit test doesn't produce any frames, either the sample is not suiteable or there is bug in the code
yes, the bug is called jetlag x_x It's fixed in the next iteration Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
