> I have several points: > > 1. Why was was this new impl not adapted to the current get_bits API? > Why do we need a giant invasive change to all of avcodec? > 2. Why was this (paid!) large patch not really discussed before just... > showing up? I really dislike the "well it's already paid for and > implemented" mentality this creates when considering whether or > not its even a good idea hasn't even been discussed.
I sent this small RFC patchset to be discussed and I'm waiting for all the opinions > 3. Some of the points aren't really good arguments for a new API, such as > "it is better documented". > 4. "it could be made a public header" -> Hell no. Don't bit a bitreader in > public API. > 5. Not sure I buy "easier to use". > 6. Where are the speed test results? You're not going to sell an invasive > patch set like this to anyone without very good benefits provided... > > Just my initial stream of thoughts. > > - Derek > > _______________________________________________ > libav-devel mailing list > [email protected] > https://lists.libav.org/mailman/listinfo/libav-devel _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
