On Tue, Jun 14, 2016 at 07:02:52AM +0200, Gwenole Beauchesne wrote: > 2016-06-10 10:49 GMT+02:00 Mark Thompson <[email protected]>: > > On 10/06/16 08:06, Anton Khirnov wrote: > >> Quoting Mark Thompson (2016-06-10 01:25:58) > >>> Adds a general mechanism for setting driver quirks, and detects the > >>> driver name to set them. > >>> > >>> When the i965 driver is being used, destroy all parameter buffers > >>> explicitly after use despite passing them to vaRenderPicture(). > >>> --- > >>> An alternative approach to solving the same problem as the previous > >>> patch. Maybe this is actually better once we start detecting the driver > >>> anyway? > >> > >> Yes, this looks much better to me. > > > > Hmm, ok. Thinking a bit further, maybe this should be available a bit more > > generally because > > <https://git.libav.org/?p=libav.git;a=blob;f=libavcodec/vaapi.c;hb=HEAD#l180> > > should also use it - maybe a property of the device rather than inside the > > encoder? > > > > A flags field in AVVAAPIDeviceContext would seem to do the right thing, but > > it > > is unclear who would initialise it - the user, or inside > > av_hwdevice_ctx_init(). > > Since most VA drivers implemented the incorrect behaviour, IMHO I > believe a better approach is to use that flag to actually enable the > correct behaviour.
Won't this change at some future point as more and more drivers implement the correct behavior? Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
