On Thu, Dec 01, 2016 at 12:35:27PM -0800, Wan-Teh Chang wrote: > On Thu, Dec 1, 2016 at 10:47 AM, Diego Biurrun <[email protected]> wrote: > > On Thu, Dec 01, 2016 at 10:22:24AM -0800, Wan-Teh Chang wrote: > >> --- /dev/null > >> +++ b/libavutil/tests/cpu_init.c > >> @@ -0,0 +1,72 @@ > > It seems a bit silly to have an empty test in the no pthreads case. > > I'd suggest building and running the test conditional on pthreads > > instead. > > This is the simplest approach. Also, after I changed HAVE_PTHREADS to > HAVE_THREADS as James suggested, this test is non-empty in the common > cases.
But why bother the uncommon cases and add ifdef clutter to the code for no gain? Just run the test conditionally on HAVE_THREADS. See e.g. tests/fate/libavcodec.mak for how it's done. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
