Quoting Vittorio Giovara (2017-01-09 13:24:21) > On Mon, Jan 9, 2017 at 1:18 PM, Anton Khirnov <[email protected]> wrote: > > Quoting Vittorio Giovara (2017-01-03 11:43:22) > >> > @@ -450,6 +451,106 @@ int attribute_align_arg > >> > avcodec_send_packet(AVCodecContext *avctx, const AVPacke > >> > return 0; > >> > } > >> > > >> > +static int calc_cropping_offsets(size_t offsets[4], const AVFrame > >> > *frame, > >> > + const AVPixFmtDescriptor *desc) > >> > >> IMO passing desc here is not ideal, deriving it from frame seems more > >> usual to me > > > > How is it better? What's the advantage? > > It's not a big deal, it just feels strange to pass `desc` in a > function argument, while any other use of AVPixFmtDescriptor is within > the function itself.
It feels even more strange to call this external API three times when just once is enough. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
