On Wed, Feb 01, 2017 at 01:12:47PM +0100, Vittorio Giovara wrote:
> On Wed, Feb 1, 2017 at 12:23 PM, Diego Biurrun <[email protected]> wrote:
> > On Wed, Feb 01, 2017 at 10:51:15AM +0100, Vittorio Giovara wrote:
> >> On Tue, Jan 24, 2017 at 6:12 PM, Diego Biurrun <[email protected]> wrote:
> >> > --- a/configure
> >> > +++ b/configure
> >> > @@ -4165,9 +4165,7 @@ EOF
> >> >
> >> > -check_cc <<EOF && enable_weak inline_asm
> >> > -void foo(void) { __asm__ volatile ("" ::); }
> >> > -EOF
> >> > +check_inline_asm inline_asm '"" ::'
> >>
> >> Is the change just a more succinct check or is there a particular reason 
> >> for it?
> >
> > The former:
> >
> > check_inline_asm(){
> >     log check_inline_asm "$@"
> >     name="$1"
> >     code="$2"
> >     shift 2
> >     disable $name
> >     check_cc "$@" <<EOF && enable $name
> > void foo(void){ __asm__ volatile($code); }
> > EOF
> > }
> 
> ok thanks for the clarification, maybe you could mention that this
> change is only a simplification and not a behavioral change.

Like this:

  configure: Simplify inline asm check with appropriate helper function

?

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to