On Tue, 14 Feb 2017, Diego Biurrun wrote:

None of them are specific to the YASM assembler.
---

Same as before, better names for the following are welcome:

-  --disable-yasm           disable use of nasm/yasm assembly
+  --disable-assembler      disable use of standalone assembly

Plain "nasm" would be possible, the syntax is nasm after all.
Or "x86-asm" or whatever better name you suggest, I don't like
any of my ideas much ..

Hmm, out of these, I'd maybe rank them like this:
1) x86-asm
2) nasm
3) yasm

I kinda dislike --disable-assembler since it doesn't sound different to --disable-asm (which disables all of it).


The patch looks mostly ok. I don't mind using "ASM" instead of "YASM" in makefiles etc, since that's mostly an internal detail. OTOH, maybe it would be ok to keep using YASM or NASM there as well. (I don't see a huge value in changing those parts tbh.)

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to