On Fri, 26 May 2017, Diego Biurrun wrote:

---
TLS is not handled like other protocols. Instead the implementation details
of which crypto library is used get exposed to the user. Hiding those
details allows simplifying and refactoring some code and avoiding the
special-casing of TLS.

This should get a slightly more elaborate log message before pushing.

configure                 |  8 ++----
libavformat/Makefile      |  3 +-
libavformat/network.c     | 20 --------------
libavformat/protocols.c   |  3 +-
libavformat/tls.c         | 70 +++++++++++++++++++++++++++++++++++++++++------
libavformat/tls.h         |  8 ------
libavformat/tls_gnutls.c  | 53 +++--------------------------------
libavformat/tls_openssl.c | 53 +++--------------------------------
libavformat/utils.c       |  4 +++
9 files changed, 77 insertions(+), 145 deletions(-)

Doesn't this partially revert parts of what was done in d8ffb2055f0e0fcb5d025bab72eb19c2a886c125? While I was the one who originally wrote in the way it was with all of the gnutls and openssl implementations all in tls.c, I don't want this code to be moving back and forth, and I now enjoy the clarity of having them cleanly separated.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to