*PLEASE* do not bottom-post.

On Mon, May 29, 2017 at 11:32:49AM +0200, wm4 wrote:
> On Mon, 29 May 2017 10:56:36 +0200
> Diego Biurrun <[email protected]> wrote:
> > ---
> > 
> > Log message still not perfect.
> > 
> > No longer tries to deduplicate parts of the implementation, just 
> > disentangles
> > the protocol declaration.
> > 
> >  configure                 |  8 ++------
> >  libavformat/Makefile      |  3 +--
> >  libavformat/network.c     | 20 --------------------
> >  libavformat/protocols.c   |  3 +--
> >  libavformat/tls.c         | 39 ++++++++++++++++++++++++++++++---------
> >  libavformat/tls.h         |  8 --------
> >  libavformat/tls_gnutls.c  | 31 ++++---------------------------
> >  libavformat/tls_openssl.c | 31 ++++---------------------------
> >  libavformat/utils.c       |  4 ++++
> >  9 files changed, 46 insertions(+), 101 deletions(-)
> 
> We have a perfectly fine way to modularize protocols (or protocol
> "filters", like TLS, encryption, etc.) - and we're using it in a good
> way.

Example?

> Why do you insist on not using this modularization, and instead
> doing it in tricky ways like #including .c source files?

The .c #include is just a detail of this patch and not particularly
hard to change.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to