On Wed, 31 May 2017 14:57:54 +0200
Diego Biurrun <[email protected]> wrote:

> TLS is currently implemented over either OpenSSL or GnuTLS, with more
> backends likely to appear in the future. Currently, those backend libraries
> are part of the protocol names used during e.g. the configure stage of a
> build. Hide those details behind a generically-named declaration for the
> TLS protocol to avoid leaking those details into the configuration stage.
> ---


> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index eaba473..fd85a02 100644
> --- a/libavformat/utils.c
> +++ b/libavformat/utils.c
> @@ -3211,8 +3211,10 @@ int avformat_network_init(void)
>      ff_network_inited_globally = 1;
>      if ((ret = ff_network_init()) < 0)
>          return ret;
> +#if CONFIG_TLS_PROTOCOL
>      ff_tls_init();
>  #endif
> +#endif
>      return 0;
>  }
>  
> @@ -3220,8 +3222,10 @@ int avformat_network_deinit(void)
>  {
>  #if CONFIG_NETWORK
>      ff_network_close();
> +#if CONFIG_TLS_PROTOCOL
>      ff_tls_deinit();
>  #endif
> +#endif
>      return 0;
>  }
>  

I think I said this in my previous reply: someone implementing a new
TLS protocol shouldn't be forced to define those just because openssl
and gnutls happen to need them.

Also I still don't get the point of this.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to