On 12/08/17 09:40, Diego Biurrun wrote:
> On Fri, Aug 11, 2017 at 12:36:56AM +0100, Mark Thompson wrote:
>> --- /dev/null
>> +++ b/libavcodec/cbs.h
>> @@ -0,0 +1,274 @@
>> +
>> +/**
>> + * Write the content of the fragment to its own internal buffer.
>> + *
>> + * Writes the content of all units and then assembles them into a new
>> + * data buffer.  When modifying the content of decomposed units, this
>> + * can be used to regenerate the bitstream form of units or the whole
>> + * fragment so that it can be extracted for other use.
>> + */
>> +int ff_cbs_write_fragment_data(CodedBitstreamContext *ctx,
>> +                               CodedBitstreamFragment *frag);
>> +
> 
> It's odd to see a Brit like you use American double spaces after a period :)
> I recently dropped the habit of double spaces, the benefit appears dubious
> and since the use is not that widespread - even among USians it seems - so
> that I fit in better with single spaces.
> 
> In case you're wondering or some outside reader is confused: this is not an
> actionable review comment, it's just random stylistic musing from my side.

As far as I know it isn't a pond-side thing, merely personal preference (the 
supreme arbiter of all human knowledge appears to agree with me: 
<https://en.wikipedia.org/wiki/Sentence_spacing>).  And I do prefer it, 
especially in monospaced text.

In any case, if you notice this sort of thing then I have to say I'm rather 
surprised that you've only just seen it now - I consistently use it everywhere, 
including IRC.

- Mark
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to