On Sat, Aug 12, 2017 at 07:21:49PM +0100, Mark Thompson wrote:
> On 12/08/17 09:40, Diego Biurrun wrote:
> > On Fri, Aug 11, 2017 at 12:36:56AM +0100, Mark Thompson wrote:
> >> --- /dev/null
> >> +++ b/libavcodec/cbs.h
> >> @@ -0,0 +1,274 @@
> >> +
> >> +/**
> >> + * Write the content of the fragment to its own internal buffer.
> >> + *
> >> + * Writes the content of all units and then assembles them into a new
> >> + * data buffer. When modifying the content of decomposed units, this
> >> + * can be used to regenerate the bitstream form of units or the whole
> >> + * fragment so that it can be extracted for other use.
> >> + */
> >> +int ff_cbs_write_fragment_data(CodedBitstreamContext *ctx,
> >> + CodedBitstreamFragment *frag);
> > It's odd to see a Brit like you use American double spaces after a period :)
> > I recently dropped the habit of double spaces, the benefit appears dubious
> > and since the use is not that widespread - even among USians it seems - so
> > that I fit in better with single spaces.
> > In case you're wondering or some outside reader is confused: this is not an
> > actionable review comment, it's just random stylistic musing from my side.
> As far as I know it isn't a pond-side thing, merely personal
> preference. And I do prefer it, especially in monospaced text.
Possibly I was confused by having to turn on French Spacing in LaTeX.
I certainly learned through using LaTeX that such a thing as two spaces
after a period was an existing convention. But I think I only ever saw
it in US context and/or used by Americans.
> (the supreme arbiter of all human knowledge appears to agree
> with me: <https://en.wikipedia.org/wiki/Sentence_spacing>)
I love what you call Wikipedia :) - in Germany we like to call it the
all-knowing Trash Heap, which you possibly remember from Fraggle Rock.
> In any case, if you notice this sort of thing then I have to say I'm
> rather surprised that you've only just seen it now - I consistently
> use it everywhere, including IRC.
I'm a stickler for detail, but that's no news to you I assume. Contrary
to the legends surrounding me, I don't comment on everything I notice,
far from it. So yes, I noticed before, I just didn't mention it. ;)
libav-devel mailing list