On Fri, Feb 09, 2018 at 08:23:28PM +0000, Mironov, Mikhail wrote: > > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Diego > > On Wed, Feb 07, 2018 at 09:46:29AM +0100, Diego Biurrun wrote: > > > On Sun, Feb 04, 2018 at 07:04:39PM +0000, Mironov, Mikhail wrote: > > > > I have a developer who will cover AMF integration on regular basis > > (together with me). He starts tomorrow and will be up to date soon. > > > > I will ask him to cleanup the things you mentioned if you will not > > > > submit > > the changes first. > > > > He is on BCC for now. > > > > > > It seems a bit more cleanup is needed on your side as well: > > > > > > /home/libav/libs/include/AMF/core/Platform.h:431:16: error: implicit > > declaration of function ‘memcmp’ [-Werror=implicit-function-declaration] > > > > > > Indeed that header is missing a string.h #include and things break on one > > of my systems. > > > > I worked around that locally and added FATE (compile) testing for AMF: > > > > https://fate.libav.org/x86_64-linux-external-libs/20180209180449 > > We will push this fix to AMF repo with upcoming update - hopefully next week.
Please include the patch I sent while you're at it. :) Let me know when the fix is public so I can get rid of my local workaround. Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
