On Sun, Feb 7, 2010 at 1:35 PM, Frank Endres <[email protected]>wrote:
> Hi ! > > cdio_get_discmode and mmc_get_discmode functions, although returning the > same type doesn't return the same information. After reading the source, I > saw that the mmc variant is incomplete (it doesn't detects DVDs), You'll find lots of things wrong when dealing with things other than CDs. > so I > completed with success this function, ... and decided to cancel the changes > after: > - I thought CDIO_DISCMODE_NO_INFO was used when no media is detected, but > after reading the source of cdio_is_discmode_cdrom, I saw that it is not > true. > - discmode mix - I think - two different types of information: CD content > and DVD media type. My opinion is that it is not a good idee to do so (it > is > somehow inconsistent - or there is something I have not understood). > Yes, this was not a good idea. I think what you did which is to redo with different routines and not try to fix this is fine.
