Rocky Bernstein wrote:
On Thu, Jun 2, 2011 at 5:15 PM, Robert William Fuller <
[email protected]> wrote:

Hi,

Was the sprintf patch applied?


Yes.


Some of the lines, such as this one:

+      snprintf(volpath, 256, "%s/s0", globbuf.gl_pathv[i]);

Should probably be like this instead:

+      snprintf(volpath, sizeof(volpath), "%s/s0", globbuf.gl_pathv[i]);


Yes,  I made changes like this when I applied the patch.

Good deal! I forget that other people can write good code. I have seen so little of it in my professional career :-) Perhaps it is one of the reasons I like free software. People take pride in their work.

Rob


Reply via email to