Yes, this looks like a good plan. Edd also has a test proposed for libcdio_paranoia that he has indicated he would like to propose that you can use. ᐧ
On Sun, Dec 30, 2018 at 5:47 AM Thomas Schmitt <scdbac...@gmx.net> wrote: > Hi, > > how wrong is this plan to create a test for track numbers: > > 1: In file test/check_cue.sh.in > Put the existing test "CD-DA" into a loop over fname: > > ------------------------------------------------------------------------------ > for fname in cdda cdda_4_5 > do > if test "$fname" = cdda_4_5 > then > testnum=CD-DA-4-5 > else > testnum=CD-DA > fi > > # (Temporary remark: Begin of existing code indented by two blanks) > > if test -f ${abs_top_srcdir}/test/data/${fname}.bin ; then > opts="--quiet --no-device-info --cue-file > ${abs_top_srcdir}/test/data/${fname}.cue --no-cddb" > test_cdinfo "$opts" ${fname}.dump ${abs_top_srcdir}/test/${fname}.right > RC=$? > check_result $RC "cd-info CUE test $testnum" "${CD_INFO} $opts" > > opts="--quiet --no-device-info --bin-file > ${abs_top_srcdir}/test/data/${fname}.bin --no-cddb" > test_cdinfo "$opts" ${fname}.dump ${abs_top_srcdir}/test/${fname}.right > RC=$? > check_result $RC "cd-info BIN test $testnum" "${CD_INFO} $opts" > else > echo "-- Don't see BIN file ${abs_top_srcdir}/test/data/${fname}.bin. > Test $testnum skipped." > fi > > # (Temporary remark: End of existing code indented by two blanks) > > done > > ------------------------------------------------------------------------------ > > 2: In directory test/data > Add file cdda_4_5.cue: > > ------------------------------------------------------------------------------ > FILE "cdda_4_5.bin" BINARY > TRACK 04 AUDIO > FLAGS DCP > INDEX 01 00:00:00 > TRACK 05 AUDIO > FLAGS DCP > INDEX 01 00:02:00 > > ------------------------------------------------------------------------------ > Create link cdda_4_5.bin -> cdda.bin > > 3: In directory test > Add file cdda_4_5.right > by: > src/cd-info --no-header --quiet --no-device-info \ > --cue-file test/data/cdda_4_5.cue --no-cddb \ > >test/cdda_4_5.right > > 4: Make sure that the new files get into the "make dist" tarball. > Still subject to research. > In test/Makefile.am : > Add cdda_4_5.right to check_DATA > ??? Find out why cdda.bin is mentioned in target make-executable > In test/data/Makefile.am > Add cdda_4_5.cue and cdda_4_5.bin to check_DATA > > > Have a nice day :) > > Thomas > > >