On Sun, Dec 30, 2018 at 10:35 AM Thomas Schmitt <scdbac...@gmx.net> wrote:
> Hi, > > > Edd also has a test proposed for > > libcdio_paranoia that he has indicated he would like to propose that you > > can use. > > I guess you mean > > https://github.com/vext01/libcdio-paranoia/blob/90382a17ad2d1aaccc5a10edaf29c62c12680c5a/test/start_track_not_one.sh.in > > The BIN/CUE tests in libcdio-paranoia look quite different from those > in libcdio. For example, no .right file but rather an awk program is > used to check the output. > > Hopping along the file list of the changeset: > I need not change configure.ac because i need no awk and make no new > script. > No need for me to expand .gitignore because my three new files shall go to > git. > In test/Makefile.am i need to register my new .right file rather than Edd's > new script. > Edd does not need to expand test/data/Makefile.am because his data get > generated. > > --------------------------------------------------------------------------- > > This all depends on my two commits to libcdio branch "trackno-higher-one". > In principle they are ready for merging. > > But in detail there is still the question of log message level: > > In order to see the error messages caused by my intentionally wrong .cue > files i had to use cdio_warn() rather than cdio_log(log_level,) as used > for all other error messages in parse_cuefile(). > > Shall i keep cdio_warn() or shall i change them to cdio_log(log_level,) ? > Changing to cdio_log is perfectly fine. Thanks. > > Have a nice day :) > > Thomas > > > ᐧ
