* Dhaval Giani <[email protected]> [2010-07-06 20:43:54]:
> On Tue, Jul 6, 2010 at 7:42 PM, Balbir Singh <[email protected]>
> wrote:
> >> If backward compatibility is your only worry, then please check out
> >> the patches I have put up at
> >> http://libcg.git.sourceforge.net/git/gitweb.cgi?p=libcg/libcgroup-context.git;a=summary
> >>
> >> While it is a bit dated, I have not received any feedback/reviews from
> >> you yet. I have received some from Lennart (privately) and have
> >> modified a few of the patches. I will push them out in sometime soon
> >> (once i get a bit more time and testing done). Could you please review
> >> and try them out as well?
> >>
> >> (The patches up there have passed testing)
> >
> > I looked at the git log and the changes were not very obvious to me, I
> > would really benefit from more details like commit logs or id to look
> > at.
> >
>
>
> b3865bad731209cb8d3c452549a0254a8f9129ba
> 9475063a590f63c2b62cce98d6d4e8e4a0841e3b
> ef03b28e53b6d94c13e04f6586497d0138ed37e0
> 6c3c5e3b26cf9bf553adebdc04b063f8147f69c2
> 1416d1f2209a0cf2db7c39d41f8e0a577a61ff44
Dhaval,
Thanks, I cloned the code and looked at it. Couple of quick questions
1. Why do we call the old code deprecated? We leave it to the users to
use which version they want and provide extensive documentation around
thread fork()/exec() issues with the older API
2. Have you thought about how we can keep cgroup_context_s extendable
without breaking too much. Ideally it is opaque so we have no problems
in terms of API, but ABI can be an issue. One way to force it would
be to pack the structure, so that there is no scope for padding and
getting offsets mixed up later.
--
Three Cheers,
Balbir
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel
