On 08/10/2010 06:33 PM, Dhaval Giani wrote: > On Tue, Aug 10, 2010 at 10:23 AM, Jan Safranek<[email protected]> wrote: >> Changelog: >> - update comments: >> - emphasize that 'dictionary' is not hash >> - emphasize that order is important >> - better describe what CG_DICT_DONT_FREE_ITEMS frees >> > > Well, if you are going to argue about names ;-). To be honest, I agree > with Balbir. The moment you say dictionary, its more of a hash in my > mind. Is there some reason we do not call the list a list?
The structure is not generic list to store any generic data inside, it just stores name=value pairs, therefore I think the name 'list' is inappropriate. In addition, I am tempted to use the structure also for parameters of an controller in struct cgroup_controller.control_value (to get rid of FILENAME_MAX and CG_VALUE_MAX arrays), but it requires rewrite of the structure from list to dynamic array (which is simple, but would require rename of the structure from 'list' to 'array' or 'vector'). Therefore I suggest name which does not say *how it is stored*, but *what is stored*. Ok, 'dictionary' may be misleading. Any other suggestions? Jan ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
