On Thu, Aug 12, 2010 at 2:41 PM, Jan Safranek <[email protected]> wrote: > On 08/11/2010 10:31 AM, Dhaval Giani wrote: >> >> e do not call the list a list? >>> >>> The structure is not generic list to store any generic data inside, it >>> just >>> stores name=value pairs, therefore I think the name 'list' is >>> inappropriate. >>> In addition, I am tempted to use the structure also for parameters of an >>> controller in struct cgroup_controller.control_value (to get rid of >>> FILENAME_MAX and CG_VALUE_MAX arrays), but it requires rewrite of the >>> structure from list to dynamic array (which is simple, but would require >>> rename of the structure from 'list' to 'array' or 'vector'). >>> >>> Therefore I suggest name which does not say *how it is stored*, but *what >>> is >>> stored*. Ok, 'dictionary' may be misleading. Any other suggestions? >>> >> >> So then why not a store? :-) > > 'store' suggests it is generic data structure. It is not, it allows only > (name, value) pairs. I'd like to see *what* is stored in the structure. I > have renamed it to 'parameter_list', but cgroup_parameter_list_create looks > too long to me, and as second option I thought about 'properties', i.e. > cgroup_properties_create - IMHO it's not descriptive enough. 'dictionary' > still looks the best to me ;)
Dictionary still would imply 1. ordering and 2. hashing we only do 1, so dictionary is certainly not the best. Now, since it is going to be internal only, let's keep it as cg_param_list ? Does that work? Dhaval ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
