On 02/21/2011 01:57 PM, Dhaval Giani wrote: > On Mon, Feb 21, 2011 at 1:50 PM, Jan Safranek<jsafr...@redhat.com> wrote: >> On 02/07/2011 05:54 PM, Dhaval Giani wrote: >>> + if (!cgrules_config_file&& !cgrules_config_dir) { >>> cgrules_config_file = strdup(CGRULES_DEFAULT_CONFIG); >>> if (!cgrules_config_file) { >> >> This decision should be made inside the library. Other apps, which use >> rules, would benefit from that and behave consistently. >> > > Did not get this exactly, this comes from the command line option, and > is set globally.
Well, the decission what's default if nothing is specified on command line should be the same in cgrulesengd and cglcassify, so I am just proposing to add it to the cgroup_parse_rules() in the library - so it is 1) written only once and 2) consistent. Jan ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel