It's not strictly necessary to check return values of these functions, we
already check *result!=NULL, which seems to be enough. But gcc complains
about set-but-unused variable, so one additional check won't harm.
Signed-off-by: Jan Safranek <jsafr...@redhat.com>
---
src/config.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/config.c b/src/config.c
index 3e67b4f..fc4901f 100644
--- a/src/config.c
+++ b/src/config.c
@@ -202,7 +202,7 @@ int cgroup_config_group_task_perm(char *perm_type, char
*value)
error = getpwnam_r(value, pw, buffer, CGROUP_BUFFER_LEN,
&pw_buffer);
- if (pw_buffer == NULL) {
+ if (pw_buffer == NULL || error) {
free(pw);
goto group_task_error;
}
@@ -223,7 +223,7 @@ int cgroup_config_group_task_perm(char *perm_type, char
*value)
error = getgrnam_r(value, group, buffer,
CGROUP_BUFFER_LEN, &group_buffer);
- if (group_buffer == NULL) {
+ if (group_buffer == NULL || error) {
free(group);
goto group_task_error;
}
@@ -276,7 +276,7 @@ int cgroup_config_group_admin_perm(char *perm_type, char
*value)
error = getpwnam_r(value, pw, buffer, CGROUP_BUFFER_LEN,
&pw_buffer);
- if (pw_buffer == NULL) {
+ if (pw_buffer == NULL || error) {
free(pw);
goto admin_error;
}
@@ -297,7 +297,7 @@ int cgroup_config_group_admin_perm(char *perm_type, char
*value)
error = getgrnam_r(value, group, buffer,
CGROUP_BUFFER_LEN, &group_buffer);
- if (group_buffer == NULL) {
+ if (group_buffer == NULL || error) {
free(group);
goto admin_error;
}
------------------------------------------------------------------------------
Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
user administration capabilities and model configuration. Take
the hassle out of deploying and managing Subversion and the
tools developers use with it.
http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
