On Thu, Aug 11, 2011 at 9:02 AM, Jan Safranek <jsafr...@redhat.com> wrote:
> fclose(NULL) dereferences its argument -> sigsegv.
>

good catch

> Signed-off-by: Jan Safranek <jsafr...@redhat.com>

Acked-by: Dhaval Giani <dhaval.gi...@gmail.com>

> ---
>
>  src/api.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/api.c b/src/api.c
> index e443ad5..71cec93 100644
> --- a/src/api.c
> +++ b/src/api.c
> @@ -1313,9 +1313,9 @@ static int cg_set_control_value(char *path, const char 
> *val)
>                                        free(tasks_path);
>                                        return ECGROUPSUBSYSNOTMOUNTED;
>                                }
> +                       } else {
> +                               fclose(control_file);
>                        }
> -
> -                       fclose(control_file);
>                        free(tasks_path);
>                        return ECGROUPNOTALLOWED;
>                }
>
>
> ------------------------------------------------------------------------------
> Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
> user administration capabilities and model configuration. Take
> the hassle out of deploying and managing Subversion and the
> tools developers use with it.
> http://p.sf.net/sfu/wandisco-dev2dev
> _______________________________________________
> Libcg-devel mailing list
> Libcg-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/libcg-devel
>

------------------------------------------------------------------------------
Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
user administration capabilities and model configuration. Take 
the hassle out of deploying and managing Subversion and the 
tools developers use with it. 
http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to