[Adding Jan to the CC list]
On Thu 22-11-12 17:47:47, Robert Milasan wrote:
>
> b55ce704 (scripts: cgconfig, cleanup) introduced a regression because
> read is now executed in a subshell so the variables are not visible
> in the outer context and so defaultcgtoup is never non-empty.
>
> Fix the issue by using here text which doesn't involve subshell.
>
> Signed-off-by: Robert Milasan <rmila...@suse.com>
>
> Index: libcgroup-0.37.1/scripts/init.d/cgconfig.in
> ===================================================================
> --- libcgroup-0.37.1.orig/scripts/init.d/cgconfig.in
> +++ libcgroup-0.37.1/scripts/init.d/cgconfig.in
> @@ -55,8 +55,8 @@ create_default_groups() {
> defaultcgroup=
>
> if [ -f /etc/cgrules.conf ]; then
> - grep -m1 '^\*[[:space:]]\+' /etc/cgrules.conf | \
> - read user ctrl defaultcgroup
> + read user ctrl defaultcgroup <<< \
> + $(grep -m1 '^\*[[:space:]]\+' /etc/cgrules.conf)
> if [ -n "$defaultcgroup" -a "$defaultcgroup" = "*" ]; then
> log_warning_msg "/etc/cgrules.conf incorrect"
> log_warning_msg "Overriding it"
>
>
> --
> Robert Milasan
>
> L3 Support Engineer
> SUSE Linux (http://www.suse.com)
> email: rmila...@suse.com
> GPG fingerprint: B6FE F4A8 0FA3 3040 3402 6FE7 2F64 167C 1909 6D1A
--
Michal Hocko
SUSE Labs
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
