On 11/22/2012 05:47 PM, Robert Milasan wrote:
>
> b55ce704 (scripts: cgconfig, cleanup) introduced a regression because
> read is now executed in a subshell so the variables are not visible
> in the outer context and so defaultcgtoup is never non-empty.
>
> Fix the issue by using here text which doesn't involve subshell.
>
> Signed-off-by: Robert Milasan <[email protected]>
Acked-by: Jan Safranek <[email protected]>
>
> Index: libcgroup-0.37.1/scripts/init.d/cgconfig.in
> ===================================================================
> --- libcgroup-0.37.1.orig/scripts/init.d/cgconfig.in
> +++ libcgroup-0.37.1/scripts/init.d/cgconfig.in
> @@ -55,8 +55,8 @@ create_default_groups() {
> defaultcgroup=
>
> if [ -f /etc/cgrules.conf ]; then
> - grep -m1 '^\*[[:space:]]\+' /etc/cgrules.conf | \
> - read user ctrl defaultcgroup
> + read user ctrl defaultcgroup <<< \
> + $(grep -m1 '^\*[[:space:]]\+' /etc/cgrules.conf)
> if [ -n "$defaultcgroup" -a "$defaultcgroup" = "*" ]; then
> log_warning_msg "/etc/cgrules.conf incorrect"
> log_warning_msg "Overriding it"
>
>
------------------------------------------------------------------------------
Keep yourself connected to Go Parallel:
VERIFY Test and improve your parallel project with help from experts
and peers. http://goparallel.sourceforge.net
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel
