Hi Libo,

>> $ ls -y
>> ls: illegal option -- y
>> usage: ls [-ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1] [file ...]
>>
>> I would like something like this.
>
>
> yes, it is the bash style. But this patch follows libcg style, this is 
> important too?
>

I am not sure I understand the comment. Why can't we do,

Illegal option $OPTION
usage()

Why is it different from libcg style?

>>>
>>>> Finally, a quick read through that code, and I can see quite a few
>>>> things that need to be changed/corrected. We are freeing up
>>>> default_cgroup even it has not be allocated. That needs to be
>>>> corrected.
>>>>
>>>
>>> Don`t worry. cgroup_free() is safe even if default_group is NULL.
>>>
>>
>> While true, there is no need to make the call if not required. So yes,
>> it is a cleanup I would like :-).
>>
>
>    This problem already exists, you can make a patch to fix it.  :)
>

Since you are touching that area, I would appreciate a patch.

Thanks!
Dhaval

------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and 
AppDynamics. Performance Central is your source for news, insights, 
analysis and resources for efficient Application Performance Management. 
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to