On 2013/8/27 21:12, Dhaval Giani wrote: > Hi Libo, > >>> $ ls -y >>> ls: illegal option -- y >>> usage: ls [-ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1] [file ...] >>> >>> I would like something like this. >> >> >> yes, it is the bash style. But this patch follows libcg style, this is >> important too? >> > > I am not sure I understand the comment. Why can't we do, > > Illegal option $OPTION > usage() > > Why is it different from libcg style?
I just follow the command cgcreate: :) /* no cgroup name */ if (argv[optind]) { fprintf(stderr, "%s: " "wrong arguments (%s)\n", argv[0], argv[optind]); ret = -1; goto err; } > >>>> >>>>> Finally, a quick read through that code, and I can see quite a few >>>>> things that need to be changed/corrected. We are freeing up >>>>> default_cgroup even it has not be allocated. That needs to be >>>>> corrected. >>>>> >>>> >>>> Don`t worry. cgroup_free() is safe even if default_group is NULL. >>>> >>> >>> While true, there is no need to make the call if not required. So yes, >>> it is a cleanup I would like :-). >>> >> >> This problem already exists, you can make a patch to fix it. :) >> > > Since you are touching that area, I would appreciate a patch. > ok, I will separate. > Thanks! > Dhaval > > ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel