On 02/26/2014 09:41 PM, Dhaval Giani wrote:
> On Tue, Feb 25, 2014 at 10:06 AM, Jan Chaloupka <jchal...@redhat.com> wrote:
>> Parser does not parse empty MOUNT body, i.e. mount {}. Can be generated by 
>> cgsnapshot with no cgroup mounted.
>> Adding new rule into parser.y resolves this problem.
>> Tested for cgconfig.conf containing mount{}.
>>
> Just curious? If you don't need the mount information, you should be
> able to use it without having it in. (though i need to go through the
> code again to confirm if either namespace/mount is mandatory).
>
> Thanks!
> Dhaval

Having no mouts, mount {} is generated. Then trying to use this config, 
it is not parsed properly and is ending with parse error. This should 
not happen. The user can delete it and then the file is fine but how 
many users can know that. They just get an error with no additional 
information about what happend. Another solution is to generated mount 
{..} only when there is at least one mount but from my point of view, 
adding new rule is the smallest change possible. And many users can 
already have config files with mount {}.

regards
Jan

------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to