On Thu, Jun 27, 2019 at 01:08:36PM -0600, Tom Hromatka 
<tom.hroma...@oracle.com> wrote:
> +    @staticmethod
> +    def concatenate_controllers(controller_list):
> +        if type(controller_list) is types.StringType:
> +            # controller is already a string.  return it as is
> +            return controller_list
> +
> +        out_str = ""
> +        for controller in controller_list:
> +            out_str += "%s," % controller
> +
> +        # remove the trailing ","
> +        out_str = out_str[:-1]
> +        return out_str
This functions is unnecessarily complex, see Python's str.join()
function.

_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to