On 7/2/19 5:50 AM, Michal Koutný wrote:
Hi.
This is drive-by review of form (some remarks posted to particular
patches), I didn't look deeper into how the actual testing is structured.
No worries. Thanks for the time you were able to
give.
On Thu, Jun 27, 2019 at 01:08:32PM -0600, Tom Hromatka
<tom.hroma...@oracle.com> wrote:
These patches add nondestructive functional test support.
I assume this is meant to be for Python 3 (these days). You shebang
lines refer to 'python' but this defaults to Python 2 in many distros.
Also you include shebang in mere modules where it's unnsecessary. I
suggest having only one executable file with the shebang and import all
other files. (Or have a wrapper call and not use shebangs at all.)
Good comments. I do want the tests to be easy to use, so I am
leaning toward two major entry points into the tests:
./ftests.py # run all or some subset of the tests
./001-cgget-basic_cgget.py # run a single test directly
I'll remove the shebangs from all of the other files, though,
as they are not intended to be invoked directly from a command
line.
Thanks!
Also, it'd be good to unify usage of the percent operator vs .format()
for string formatting.
Thanks. My usage of % is definitely old school. I'll switch
over to using the preferred .format() nomenclature.
HTH,
Michal
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
