On 7/2/19 5:50 AM, Michal Koutný wrote:
Hi.
This is drive-by review of form (some remarks posted to particular
patches), I didn't look deeper into how the actual testing is structured.
On Thu, Jun 27, 2019 at 01:08:32PM -0600, Tom Hromatka
<tom.hroma...@oracle.com> wrote:
These patches add nondestructive functional test support.
I assume this is meant to be for Python 3 (these days). You shebang
lines refer to 'python' but this defaults to Python 2 in many distros.
Also you include shebang in mere modules where it's unnsecessary. I
suggest having only one executable file with the shebang and import all
other files. (Or have a wrapper call and not use shebangs at all.)
So I did some googling, and it looks like "#!/usr/bin/env python" is
the preferred syntax for python scripts that can run on both python v2
and v3. (Aside - I broke a couple things in these scripts for Python v3,
andwill have them fixed in the next version of this patchset.)
I am leaning toward supporting both python v2 and v3 for awhile, especially
since some distros I use still lean more toward python v2.
Thoughts?
Thanks.
Tom
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
