On Tue, Sep 24, 2019 at 1:36 PM Tom Hromatka <tom.hroma...@oracle.com> wrote: > > This patchset enables continuous integration, via Travis CI, > and code coverage via Coveralls. Travis CI runs all unit > and functional tests with the --enable-code-coverage flag > passed into ./configure. Coveralls then utilizes this > coverage data in its reports. > > Finally, this patchset also makes a few other noteworthy > changes: > * Switch to using LXD to simplify sharing data between the > host and the container. Previously it was using LXC > * Legacy tests are now disabled (but still in the repo) > * Default to python3 for the functional tests >
So, I am not the happiest about you mixing up unrelated bits of code in the same patchset. Some of these should really be reviewed independent of each other. For the next time, please separate things out into different logical chunks. > Travis CI results for my user branch are available here: > https://travis-ci.com/drakenclimber/libcgroup/builds > > Coveralls results (currently 16% code coverage!) are > available here: > https://coveralls.io/github/drakenclimber/libcgroup > > These patches are also available on a github branch here: > https://github.com/drakenclimber/libcgroup/tree/issues/travisci > > Tom Hromatka (7): > tests: Update googletest settings to work with Travis CI > tests: Minor changes to the functional tests for Travis CI > tests: Default the functional tests to python3 > tests: Disable the legacy tests > tests: Add Travis CI yaml configuration file > tests: Switch to using LXD for functional tests > tests: Enable code coverage after a successful Travis CI build > I only had minor comments (on commit logs and all). Once all of that is sorted out, Reviewed-by: Dhaval Giani <dhaval.gi...@oracle.com> > .gitignore | 3 + > .travis.yml | 62 ++++++ > bootstrap.sh | 16 +- > configure.in | 42 ++-- > m4/ax_code_coverage.m4 | 264 +++++++++++++++++++++++++ > src/Makefile.am | 8 +- > src/tools/Makefile.am | 24 +++ > tests/Makefile.am | 4 +- > tests/ftests/001-cgget-basic_cgget.py | 2 +- > tests/ftests/cgroup.py | 4 +- > tests/ftests/config.py | 2 +- > tests/ftests/consts.py | 10 +- > tests/ftests/container.py | 140 +++++-------- > tests/ftests/ftests.py | 74 +++++-- > tests/ftests/run.py | 9 +- > tests/gunit/Makefile.am | 13 +- > tests/tools/cgclassify/Makefile.am | 4 +- > tests/tools/cgconfigparser/Makefile.am | 6 +- > tests/tools/multimount/Makefile.am | 4 +- > 19 files changed, 529 insertions(+), 162 deletions(-) > create mode 100644 .travis.yml > create mode 100644 m4/ax_code_coverage.m4 > > -- > 2.21.0 > > > > _______________________________________________ > Libcg-devel mailing list > Libcg-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/libcg-devel _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
