On 1/16/20 10:43 AM, Nikola Forró wrote:
When setting cgroup parameters with cgset fails, no error is reported.
This is caused by the fact that cgroup_copy_controller_values is not
preserving dirty flags of the values, so it's making all errors
considered non-fatal.
Good find. While we're at it, should we add some teststhat use a
"compare_controller_values()" function to verify the copy worked
properly for various cgroup_controller values?
Thanks.
Tom
Signed-off-by: Nikola Forró <nfo...@redhat.com>
---
src/api.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/api.c b/src/api.c
index 959a814..e7a07cf 100644
--- a/src/api.c
+++ b/src/api.c
@@ -1751,6 +1751,7 @@ static int cgroup_copy_controller_values(struct
cgroup_controller *dst,
dst_val = dst->values[i];
strncpy(dst_val->value, src_val->value, CG_VALUE_MAX);
strncpy(dst_val->name, src_val->name, FILENAME_MAX);
+ dst_val->dirty = src_val->dirty;
}
err:
return ret;
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
